Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly #include cstdint.h for GCC 15 #111

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Explicitly #include cstdint.h for GCC 15 #111

merged 1 commit into from
Feb 1, 2025

Conversation

jamesjer
Copy link
Contributor

GCC 15 has streamlined some headers, with the result that cstdint.h is no longer implicitly included in some places where it used to be. The ethos build fails with error messages such as this:

In file included from /builddir/build/BUILD/ethos-0.1.1-build/ethos-ethos-0.1.1/src/lexer.cpp:9:
/builddir/build/BUILD/ethos-0.1.1-build/ethos-ethos-0.1.1/src/lexer.h:28:3: error: ‘uint32_t’ does not name a type
   28 |   uint32_t d_line;
      |   ^~~~~~~~
/builddir/build/BUILD/ethos-0.1.1-build/ethos-ethos-0.1.1/src/lexer.h:21:1: note: ‘uint32_t’ is defined in header ‘<cstdint>’; this is probably fixable by adding ‘#include <cstdint>’

@ajreynol ajreynol self-requested a review February 1, 2025 17:39
ajreynol
ajreynol approved these changes Feb 1, 2025
View reviewed changes
Copy link
Member

@ajreynol ajreynol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ajreynol ajreynol merged commit 77e6aec into cvc5:main Feb 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajreynol ajreynol ajreynol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesjer @ajreynol